Skip to content

fix: separate benchmark smoke and rerun concurrency #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakew7 merged 2 commits into from
Oct 25, 2026
Merged

fix: separate benchmark smoke and rerun concurrency #1164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1a77e
fix: separate benchmark smoke and rerun concurrency
dxnnystyles Oct 25, 2026
3789052
test: avoid optional YAML dependency in workflow regression
dxnnystyles Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/benchmark-diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ permissions:
pull-requests: write

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || inputs.pr }}
# Keep smoke runs separate from full reruns; unrelated label events get a no-op group.
group: ${{ github.workflow }}-${{ github.event.pull_request.number || inputs.pr }}-${{ (github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'rerun-benchmark')) && 'full' || (github.event_name == 'pull_request' && github.event.action != 'labeled') && 'smoke' || 'noop' }}
cancel-in-progress: true

jobs:
Expand Down
25 changes: 25 additions & 0 deletions tests/test_workflow_concurrency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
from pathlib import Path
import re


def test_benchmark_diff_separates_smoke_and_full_rerun_concurrency_groups():
workflow_path = Path(__file__).parents[1] / ".github/workflows/benchmark-diff.yml"
workflow = workflow_path.read_text(encoding="utf-8")
match = re.search(
r"(?ms)^concurrency:\n(?P<block>(?:^[ \t]+.*(?:\n|$)|^[ \t]*\n)*)",
workflow,
)
assert match is not None
concurrency = match.group("block")

group_match = re.search(r"(?m)^ group: (.+)$", concurrency)
assert group_match is not None

assert group_match.group(1) == (
"${{ github.workflow }}-${{ github.event.pull_request.number || inputs.pr }}-"
"${{ (github.event_name == 'workflow_dispatch' || "
"(github.event_name == 'pull_request' && github.event.action == 'labeled' && "
"github.event.label.name == 'rerun-benchmark')) && 'full' || "
"(github.event_name == 'pull_request' && github.event.action != 'labeled') && 'smoke' || 'noop' }}"
)
assert re.search(r"(?m)^ cancel-in-progress: true\s*$", concurrency)
Loading