Repository navigation
Give explainer table header cells scope="col" - #1183
Merged
Merged
Conversation
Signed-off-by: minutechreview <141821420+minutechreview@users.noreply.github.com>
minutechreview
requested review from
Shreyash0712,
ahmdkaml,
propcgamer20-png and
yakew7
as code owners
October 25, 2026 14:15
Contributor
|
@minutechreview is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 @Shreyash0712 @ahmdkaml @propcgamer20-png - new PR touching a path you own, please review. |
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explainer table header cells now carry
scope="col", so screen readers tie each cell to its column header.Type
Details
scripts/build_explainers.py: the<th>cells in a rendered markdown table's<thead>getscope="col".assets/explainers-ui.js: the same change in the client-siderenderMarkdownport, to keep the two renderers in parity.scripts/build_explainers.py(50 pages contain tables). The only diff in the generated HTML is the added attribute. A rebuild also bumped thedecision-curve-analysis-by-grouplastmod/dateModified because of today's commit to its markdown; I left that out to keep this change to the one fix.test_render_markdown_gives_every_table_header_a_column_scoperenders a fixture table and checks both renderers. It fails without the change.Checks:
tests/test_build_explainers.py26 passed,ruff check,check_em_dash.pyandcheck_generated_files_current.pypass.grep -l '<table' explainers/*.html | xargs grep -L 'scope=' | wc -lnow prints 0.Linked issue
Closes #1172