Repository navigation
Renovate: one group for every @wordpress/* package - #52316
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
anomiex
left a comment
There was a problem hiding this comment.
LGTM, other than the inline comment. I wonder if we could also get rid of these:
Lines 180 to 183 in 63fcbcb
Lines 197 to 200 in 63fcbcb
BTW, merging this will probably cause Renovate to close #52187 in favor of re-creating #52188 (although it probably won't do the latter automatically). Just noting that so you're not surprised if it happens.
Deps are now `>=20`.
Proposed changes
monorepo:wordpressrule, so every@wordpress/*package updates in one PR, and move the extra review teams to that rule.Revives #50868. The two trains pin exact versions of each other:
@wordpress/noticestypes are generated against@wordpress/data, and@wordpress/dataviewspeers on@wordpress/components. While the groups were separate, each bundled round only went green after folding the externalized round into it (#51701 folded #50982, #52187 folded #52188), and until the second PR landed the tree carried two copies ofcomponents,elementandcore-data, which roughly doubled the DataViews-heavy Jest suites.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
.github/renovate.json5parses as JSON5 and has a singlemonorepo:wordpressrule carrying the six review teams; no rule named "Bundled @wordpress/* monorepo" remains.