Skip to content

Renovate: one group for every @wordpress/* package - #52316

Merged
tbradsha merged 14 commits into
trunkfrom
update/renovate-merge-wp-groups
Sep 30, 2026
Merged

tbradsha merged 14 commits into
trunkfrom
update/renovate-merge-wp-groups

Conversation

@retrofox

Copy link
Copy Markdown
Contributor

Proposed changes

  • Fold the "Bundled @wordpress/* monorepo" Renovate group into the monorepo:wordpress rule, so every @wordpress/* package updates in one PR, and move the extra review teams to that rule.
  • Drop the wp-build-polyfills webpack comment that pointed at the removed group.

Revives #50868. The two trains pin exact versions of each other: @wordpress/notices types are generated against @wordpress/data, and @wordpress/dataviews peers on @wordpress/components. While the groups were separate, each bundled round only went green after folding the externalized round into it (#51701 folded #50982, #52187 folded #52188), and until the second PR landed the tree carried two copies of components, element and core-data, which roughly doubled the DataViews-heavy Jest suites.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • .github/renovate.json5 parses as JSON5 and has a single monorepo:wordpress rule carrying the six review teams; no rule named "Bundled @wordpress/* monorepo" remains.
  • On the next Renovate run, the dependency dashboard (Renovate Dependency Updates #23363) lists one "wordpress monorepo" update covering bundled and externalized packages alike.

revives #50868: the bundled and externalized trains pin each other, so separate PRs left two copies of components, element and core-data in the tree until both landed (#51701, #52187)
@retrofox
retrofox requested a review from a team as a code owner September 15, 2026 07:49
@retrofox retrofox self-assigned this Sep 15, 2026
@retrofox
retrofox requested a review from anomiex September 15, 2026 07:49
@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/renovate-merge-wp-groups branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/renovate-merge-wp-groups
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/renovate-merge-wp-groups

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

jp-launch-control Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@anomiex anomiex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the inline comment. I wonder if we could also get rid of these:

jetpack/.pnpmfile.cjs

Lines 180 to 183 in 63fcbcb

// Broaden this one further, because they're linked upstream but we update them in different Renovate PRs.
if ( pkg.peerDependencies[ '@wordpress/theme' ] ) {
pkg.peerDependencies[ '@wordpress/theme' ] = '*';
}

jetpack/.pnpmfile.cjs

Lines 197 to 200 in 63fcbcb

// Broaden this one further, because they're linked upstream but we update them in different Renovate PRs.
if ( pkg.peerDependencies[ '@wordpress/theme' ] ) {
pkg.peerDependencies[ '@wordpress/theme' ] = '*';
}

BTW, merging this will probably cause Renovate to close #52187 in favor of re-creating #52188 (although it probably won't do the latter automatically). Just noting that so you're not surprised if it happens.

Comment thread .github/renovate.json5 Outdated
@tbradsha
tbradsha merged commit 46bf34c into trunk Sep 30, 2026
120 checks passed
@tbradsha
tbradsha deleted the update/renovate-merge-wp-groups branch September 30, 2026 18:47
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants