Repository navigation
test(o63): fix main Windows CI — skip pty-based first-run e2e on win32 - #73
Closed
QiaolongLi1201 wants to merge 10 commits into
Closed
QiaolongLi1201 wants to merge 10 commits into
QiaolongLi1201 wants to merge 10 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…r accepts D:/ paths
… is not racy on win32
… (platform limit)
…folderPathKey on win32
…gs so quoted paths work [QA security review]
…32 quoted commands work; drop test-side quote workaround [QA security review]
Merged
3 tasks
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #69 — stacked on #69 head
b8a4e4b9(basesync/fork-prs-20261010); will rebase onto main after #69 merges.Problem (O63)
On Windows,
test/cli-first-run-e2e.spec.mjs:248fails withModuleNotFoundError: No module named 'fcntl'. The spec drives the CLI through a Pythonpty/fcntl/termioshelper (lines ~92/102), which only exists on POSIX.Fix
Test-only. On
win32the whole spec is skipped with a printed[SKIP]reason (all 5drivePtyjourneys depend on the POSIX pty helper). This means the fresh-home first-run scenarios lose Windows coverage until a ConPTY-based driver exists. Non-Windows assertions/behaviour are unchanged. Nosrc/changes. Written independently (no cherry-picks from other branches).Verification
npm run verify: EXIT=0