Skip to content

Remove remaining lab- and study-specific content - #18

Open
OlgaPushkarev wants to merge 1 commit into
mainfrom
remove-lab-specific-content
Open

OlgaPushkarev wants to merge 1 commit into
mainfrom
remove-lab-specific-content

Conversation

@OlgaPushkarev

@OlgaPushkarev OlgaPushkarev commented Oct 10, 2026 •

Copy link
Copy Markdown

Summary

Removes the remaining lab-, cluster- and study-specific content so the public-content guard (CI) passes. main has failed this check since the 29 September commit: the workflow scans the whole tree, and 129 hits were left in 15 files.

First of three stacked PRs (please merge in order):

  1. Remove remaining lab- and study-specific content #18 (this PR): lab-content cleanup.
  2. Format all Python files with ruff (format-only) #19: ruff format of all Python files (format-only).
  3. Support non-perturbed scRNA-seq and mouse data #20: support for non-perturbed scRNA-seq and mouse data.

Changes

  • Annotation runners (C_Annotation/*/run_*.sh):
    • Use PIPELINE_ROOT for SCRIPT_DIR. This also fixes paths into an AGeneTic/ folder that doesn't exist in the repo, so these runners did not work from a fresh clone.
    • Activate conda with conda shell.bash hook instead of a personal install.
    • Use <partition>, and quoted /path/to/... placeholders for result directories.
  • run_add_umap.sh:
    • PIPELINE_ROOT-relative SCRIPT_DIR.
    • The log directory is configurable (ADD_UMAP_LOG_DIR, default ./add_umap_logs) and is passed explicitly when the script resubmits itself.
    • <partition> / <your_email> placeholders.
    • Sizing notes no longer name datasets; instructions added for the manual sbatch path.
  • gpe_export.py: reads the GeneProgramExplorer location from a GPE_DIR environment variable, with a clear error when it is missing.
  • Wording: generic text in two test usage blocks, search_nature.py, a --cell_type help example, and two comments/messages that named specific datasets.
  • CHANGELOG entry.

Testing

  • python3 tools/check_no_lab_specific_content.py (full tree, as in CI): no hits.
  • All tracked .sh files pass bash -n, and every script path they reference exists. All tracked .py files compile.
  • The two HTML no-perturb test files pass (8/8).
  • gpe_export raises the intended error when GPE_DIR is wrong.

The annotation runners and gpe_export.py pointed to a collaborator's personal folders, so local copies that relied on those paths need PIPELINE_ROOT / GPE_DIR set.

🤖 Generated with Claude Code

The public-content guard (CI) scans the full tree and has been failing on
content already on main. Replace it with placeholders and portable defaults:

- Annotation runners (C_Annotation/*/run_*.sh): use PIPELINE_ROOT for
  SCRIPT_DIR (also fixing paths into a nonexistent AGeneTic/ folder),
  `conda shell.bash hook` instead of a personal conda install,
  <partition>, and /path/to placeholders for result directories.
- run_add_umap.sh: PIPELINE_ROOT-relative SCRIPT_DIR, configurable log
  directory (ADD_UMAP_LOG_DIR) passed explicitly on self-resubmission,
  <partition>/<your_email>, generic sizing notes, and log-directory
  instructions for the manual sbatch path.
- gpe_export.py: GeneProgramExplorer location from the GPE_DIR environment
  variable, with a clear error when it is missing.
- Generic wording in test usage text, search_nature.py, a --cell_type help
  example, and two comments/messages that named specific datasets.

tools/check_no_lab_specific_content.py now reports no hits.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant