Repository navigation
Remove remaining lab- and study-specific content - #18
Open
OlgaPushkarev wants to merge 1 commit into
Open
OlgaPushkarev wants to merge 1 commit into
OlgaPushkarev wants to merge 1 commit into
Conversation
The public-content guard (CI) scans the full tree and has been failing on content already on main. Replace it with placeholders and portable defaults: - Annotation runners (C_Annotation/*/run_*.sh): use PIPELINE_ROOT for SCRIPT_DIR (also fixing paths into a nonexistent AGeneTic/ folder), `conda shell.bash hook` instead of a personal conda install, <partition>, and /path/to placeholders for result directories. - run_add_umap.sh: PIPELINE_ROOT-relative SCRIPT_DIR, configurable log directory (ADD_UMAP_LOG_DIR) passed explicitly on self-resubmission, <partition>/<your_email>, generic sizing notes, and log-directory instructions for the manual sbatch path. - gpe_export.py: GeneProgramExplorer location from the GPE_DIR environment variable, with a clear error when it is missing. - Generic wording in test usage text, search_nature.py, a --cell_type help example, and two comments/messages that named specific datasets. tools/check_no_lab_specific_content.py now reports no hits. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the remaining lab-, cluster- and study-specific content so the public-content guard (CI) passes.
mainhas failed this check since the 29 September commit: the workflow scans the whole tree, and 129 hits were left in 15 files.First of three stacked PRs (please merge in order):
ruff formatof all Python files (format-only).Changes
C_Annotation/*/run_*.sh):PIPELINE_ROOTforSCRIPT_DIR. This also fixes paths into anAGeneTic/folder that doesn't exist in the repo, so these runners did not work from a fresh clone.conda shell.bash hookinstead of a personal install.<partition>, and quoted/path/to/...placeholders for result directories.run_add_umap.sh:PIPELINE_ROOT-relativeSCRIPT_DIR.ADD_UMAP_LOG_DIR, default./add_umap_logs) and is passed explicitly when the script resubmits itself.<partition>/<your_email>placeholders.sbatchpath.gpe_export.py: reads the GeneProgramExplorer location from aGPE_DIRenvironment variable, with a clear error when it is missing.search_nature.py, a--cell_typehelp example, and two comments/messages that named specific datasets.Testing
python3 tools/check_no_lab_specific_content.py(full tree, as in CI): no hits..shfiles passbash -n, and every script path they reference exists. All tracked.pyfiles compile.gpe_exportraises the intended error whenGPE_DIRis wrong.The annotation runners and
gpe_export.pypointed to a collaborator's personal folders, so local copies that relied on those paths needPIPELINE_ROOT/GPE_DIRset.🤖 Generated with Claude Code