Ignore the node-forge advisory until a fix is published - #1086
Merged
Merged
Conversation
GHSA-86w9-cpqp-85rv affects RSA PKCS#1 v1.5 signature verification in node-forge up to 1.4.0, which arrives only through @parse/node-apn for certificate-based APNs credentials. HealthLog uses token authentication, so that path never runs, and no patched release exists yet.
Same advisory, same reasoning as the pnpm audit entry: the affected signature verification sits in node-apn's certificate credential path, which token-authenticated APNs never reaches, and no fix is published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm audit --prod --audit-level=highnow reports GHSA-86w9-cpqp-85rv (node-forge <= 1.4.0, RSA PKCS#1 v1.5 signature verification), which would turn the blocking audit on main and the daily schedule red.@parse/node-apn, which uses it in its certificate-based credential path (credentials/certificate/*: p12 / PEM certificate). HealthLog authenticates to APNs with a token (.p8 key viaAPNS_KEY_ID/APNS_TEAM_ID), so the affected code never runs.auditConfig.ignoreGhsas(pnpm-workspace.yaml) carries the reason and the instruction to remove it and raise the floor once 1.4.1 is published.