Repository navigation
Read Provider declarations in Web - #539
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web now branches on what each Sandbox Provider declares, not on its name.
DeploymentPolicymoves into the Provider protocol file (sandbox_provider.go) and gains the adapter's default sandbox size. Docker declares 2 CPU / 2048 MiB, microsandbox 2 / 4096 / 8192 / 8192, and E2B none, since its template sets the size. Registration checks that a declared default passes the adapter's ownValidateResources.Registry.DeploymentContract()builds one contract, andcmd/specification-contractwrites it to bothnode_spec.pyandpackages/agents-client/src/deployment-contract.ts. Each provider entry carriesmode,disk,runtimeanddefault_resources.SandboxProvideris derived from the generated keys; the hand-copied union, theprovidersSet andstandard-sizes.jsonare deleted.deployment.modeanddeployment.suspension. For a choice not yet saved, it reads the generated entry. Host requirements are one Provider-neutral line, because the installer already checks them. Remaining name comparisons are display labels, the E2B wizard step and the Docker confirmation, both deferred until the Provider protocol declares configuration fields.sandbox-provider.md(en and zh) describes the declaration and its projections and narrows the known gap to the wizard exception.Checks:
go build,go vet, the Go tests forsandbox/...,deployment/...andcmd/specification-contract; the projection is stable (-writetwice, no diff); agents-client typecheck and tests; Web typecheck and the focused vitest files; translation and link checks;check-names. Playwright is left to CI.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.