Skip to content

fix(generator): preserve effective schema metadata - #232

Merged
leoafarias merged 2 commits into
fix/2.0-json-schema-vocabulariesfrom
fix/2.0-generator-schema-metadata
Oct 27, 2026
Merged

leoafarias merged 2 commits into
fix/2.0-json-schema-vocabulariesfrom
fix/2.0-generator-schema-metadata

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Schema aliases and overrides could generate fields whose required, nullable, or default behavior disagreed with runtime validation.

  • Follow schema variables and getters, honoring explicit overrides and the final .strict() or .passthrough() call.
  • Report unsupported object-shape changes at the source instead of generating incorrect fields; outer value codecs remain supported.

Follow-up #244 validates inherited field names against an alias’s final capture policy.

Validation

  • Regressions for aliases, defaults, flag overrides, shape changes, and static schema methods passed.
  • Clean generation, analysis, runtime round trips, and repeat-build checks passed.

@leoafarias
leoafarias marked this pull request as ready for review October 26, 2026 16:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T00:03:44.296565Z 56affdb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoafarias
leoafarias added this pull request to stack #238 October 26, 2026 16:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56affdb027

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@leoafarias
leoafarias merged commit 726ce43 into release/2.0 Oct 27, 2026
9 of 14 checks passed
@leoafarias
leoafarias deleted the fix/2.0-generator-schema-metadata branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant