Skip to content

fix(generator): validate alias capture member names - #244

Merged
leoafarias merged 2 commits into
fix/2.0-discriminated-codec-outputfrom
fix/2.0-alias-capture-names
Oct 27, 2026
Merged

leoafarias merged 2 commits into
fix/2.0-discriminated-codec-outputfrom
fix/2.0-alias-capture-names

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A passthrough alias could generate duplicate additionalProperties members after inheriting a field with that name.

  • Validate inherited names against the final capture policy in the existing naming pass.
  • Keep variables, getters, chained aliases and strict resets consistent. No public API or valid generated-output changes.

Follow-up to the #232 review finding, stacked on #243.

Validation

  • 3,250 workspace tests passed, including 742 generator tests and 14 naming cases; four regressions failed before the fix.
  • Analysis, formatting, 67 Chrome cases, alpha.1 API compatibility and five zero-warning publish dry runs passed.
  • CI and release preflight passed on f3584be, including both minimum SDKs and clean regeneration.

Four live Firebase tests remain skipped.

@leoafarias
leoafarias marked this pull request as ready for review October 27, 2026 01:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T01:08:09.053840Z f3584be Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoafarias
leoafarias merged commit 3a980ea into release/2.0 Oct 27, 2026
7 checks passed
@leoafarias
leoafarias deleted the fix/2.0-alias-capture-names branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant