Skip to content

fix(ack): discover bundled custom schema dialects - #239

Merged
leoafarias merged 2 commits into
chore/2.0-alpha.2-readinessfrom
fix/2.0-bundled-dialect-discovery
Oct 27, 2026
Merged

leoafarias merged 2 commits into
chore/2.0-alpha.2-readinessfrom
fix/2.0-bundled-dialect-discovery

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A schema could reject its own bundled custom dialect with unsupported_dialect before discovering it.

  • Find the selected dialect through active schema locations, while leaving annotation data untouched.
  • Cover relative IDs, mixed dialects, duplicate IDs, and required-vocabulary checks on VM and Chrome.

Follow-up to the #231 review finding, stacked on #237.

Validation

  • Discovery regressions passed on VM and Chrome, alongside the full workspace and JSON Schema conformance checks.
  • Both minimum SDKs, API compatibility, clean regeneration and all five zero-warning publish dry runs passed.
  • CI and release preflight passed on babddea.

Four live Firebase tests remain skipped. #240 was merged separately into the release base; this PR remains unmerged. No tag or package publication is part of this work.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T00:02:34.590963Z babddea New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leoafarias
leoafarias merged commit 7b7da99 into release/2.0 Oct 27, 2026
7 of 14 checks passed
@leoafarias
leoafarias deleted the fix/2.0-bundled-dialect-discovery branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant