Skip to content

fix(ack): preserve custom JSON Schema vocabulary semantics - #231

Merged
leoafarias merged 2 commits into
fix/2.0-duration-overflowfrom
fix/2.0-json-schema-vocabularies
Oct 27, 2026
Merged

leoafarias merged 2 commits into
fix/2.0-duration-overflowfrom
fix/2.0-json-schema-vocabularies

Conversation

@leoafarias

@leoafarias leoafarias commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Custom JSON Schema dialects could treat disabled keywords as validation rules. Export could also change annotation data or lose constraints.

  • Respect the dialect's active vocabularies during import and export.
  • Preserve annotations, references, null rules, and explicit format checks without activating unrelated keywords.
  • Accept identical supplied standard schemas without weakening duplicate-ID checks.

Follow-up #239 discovers selected custom dialects bundled under active schema keywords.

Validation

  • 29 regressions added; full core tests and 78 JSON Schema conformance checks passed.
  • Browser contract suite: 69 passed, two native-only skips. Analysis and formatting passed.
  • CI and release preflight passed on 9f2c9a5.

@leoafarias
leoafarias marked this pull request as ready for review October 26, 2026 16:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T00:02:25.836779Z 9f2c9a5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d55d341b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/ack/lib/src/json_schema/json_schema_compiler.dart
@leoafarias
leoafarias merged commit edf5bbf into release/2.0 Oct 27, 2026
7 of 14 checks passed
@leoafarias
leoafarias deleted the fix/2.0-json-schema-vocabularies branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant