Repository navigation
[miniflare] Add isolated native Git client for Artifacts [1/3] - #16176
Conversation
|
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
The PR description check is failing solely because this internal-only Git client layer has no changeset. PR #16177 carries the release changeset for the simulator. Could a maintainer apply |
7f12244 to
0cc04a3
Compare
edmundhung
left a comment
There was a problem hiding this comment.
The Windows CI error seems legit. But otherwise LGTM.
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
|
Thanks for the review, @edmundhung! The Windows failure was in the new test fixture: Windows cannot create |
|
Current-head CI at |
|
@edmundhung seems green now! Feel free to merge whenever you're ready! :) |
Artifacts local-development stack — 1 of 3
mainmainafter 1/3mainafter 2/3Review and merge in order: 1/3, 2/3, then 3/3. The fork-only review PRs were closed. #16092 is now closed as an unchanged full-stack reference; do not merge it in addition to the stack.
Scope
GitClientfor repository initialization, import, fork, reads, and first-parent history.Validation
pnpm -r --filter miniflare... buildpnpm --filter miniflare exec vitest run test/plugins/artifacts/git-client.spec.ts— 23 passed, 1 Windows-only test skipped locallypnpm --filter miniflare check:type; type-aware lint and formatting on changed filesAn internal-only module does not need a release changeset yet;
ci:no-changeset-requiredis applied. The opt-in simulator in part 2 carries the Miniflare changeset.