Repository navigation
Conversation
This was referenced Oct 9, 2026
Owner
Author
|
Closing this fork-only review PR as requested. The replacement will target cloudflare/workers-sdk directly; the branch and commits remain available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artifacts local-development stack — 2 of 3
Review-only fork PR. Do not merge this PR into the fork. Review in order, then merge corresponding upstream PRs in order: 1/3 — native Git client (upstream #16176) → 2/3 — opt-in simulator (this PR) → 3/3 — development tools and local default (fork #2). This PR is based on 1/3 and shows only the simulator layer. Once 1/3 merges upstream, this layer will be opened as a new upstream PR against
main; then 3/3 follows. #16092 remains an unchanged full-stack reference, not another PR to merge.What changes
dev.remote: false. An omitted setting retains existing remote behavior; the final development-tools layer changes the default.The simulator builds on the original prototype by @GregBrimble. Focused local tests establish tested behavior, not parity with the deployed service. The guarded live comparator has not been run: it needs authorization for an exclusively reserved disposable namespace. Explicit HTTPS imports can contact the supplied host, including private-network destinations, and do not follow HTTP redirects.
Validation
pnpm -r --filter miniflare... buildpnpm --filter miniflare exec vitest run test/plugins/artifacts test/config/v4-convert.spec.ts— 82 focused tests passed (including inherited Git-client tests)