Repository navigation
[vite-plugin] Backport caller-owned Container guidance to v1 - #16334
petebacondarwin wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 98b8c2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dario-piotrowicz (author of #16225) and @edmundhung (verified human ant-core approver), could you please check this The adaptation preserves v1's per-Worker Container planning and legacy configuration filenames while passing caller-owned registry guidance from both dev and preview. Public Container/deployment helper source stays absent; the manifests pin the pending releases instead. Earlier backport #16333 supplies the coupled Miniflare, Wrangler, and runtime-types versions, without repeating or reverting those bumps here. This draft awaits npm publication and final dependency/build/type/test validation, as detailed in the description. |
3866994 to
1319581
Compare
1319581 to
d911fb2
Compare
commit: |
|
Codeowners approval required for this PR:
|
|
✅ Approved — No issues found. The backport picks the Container setup guidance's config filename and registry command in the order the description gives, and the dependency pins are exact and match the lockfile. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: Low. The pull request pins 🔒 Security: ✅ LGTMNo security issues in the changed code. 📖 AGENTS.md: ✅ LGTMThe change follows the repository guidelines:
📋 Code Quality: ✅ LGTMI found no defects in the changed code.
⚡ Performance: ✅ LGTMNo performance issues in the changed code. 📝 Documentation: ✅ LGTMThe plugin changeset is present and describes the user-facing change. Reviewed commit: |
d911fb2 to
98b8c2f
Compare
Backport #16225 to Vite plugin v1, stacked on #16333, so Container setup instructions use the appropriate registry command and configuration location in both dev and preview.
Preserve v1's per-Worker image planning and legacy configuration filenames. For inline configuration, use the actual Vite configuration filename when available, or describe the Vite plugin configuration when there is no file. Use
cloudflare.config.tsonly for the experimental new-config mode; preview uses its generated Worker configuration. Keep the experimental cf delegate's registry command. Regression coverage includes real inline-config dev and build/preview servers; the two fileless-guidance cases fail against the old helper.Pin published containers-shared
0.23.0in the plugin and deploy-helpers0.22.0in private remote-bindings, with a regenerated lockfile. #16333 supplies the coupled Miniflare, Wrangler, workerd, Workers types, and runtime-types versions; no runtime bump is repeated or reverted. Retain all private workspace packages and references, and keep absent public sibling source out of v1. This original retains its own adaptation, tests, and plugin patch changeset.Validation on Node.js 22.22.1 / pnpm 10.33.0: this PR passes build (3 tasks), all retained unit tasks (8 tasks, 282 plugin tests), and all repository checks (60 tasks). The final stack additionally passes offline frozen installation and 285 plugin tests. Cross-platform CI and maintainer review remain required.
Note
This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.