Skip to content

Forward view to the simulator server and point vite at the app's build roots - #1

Merged
dashersw merged 1 commit into
mainfrom
fix/web-simulate-packaged-context
Sep 22, 2026
Merged

dashersw merged 1 commit into
mainfrom
fix/web-simulate-packaged-context

Conversation

@puskuruk

@puskuruk puskuruk commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added support for configuring simulator views with supported parameters.
    • Simulator launch URLs now include selected view settings.
  • Bug Fixes

    • Improved web app loading by ensuring public assets and the application entry page are served correctly.
    • Updated web distribution handling for more reliable simulator startup.

@puskuruk

Copy link
Copy Markdown
Collaborator Author

recheck

@dashersw

Copy link
Copy Markdown
Collaborator

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c0925106-b2d4-418c-a4ed-dff3f217e972

📥 Commits

Reviewing files that changed from the base of the PR and between 0c3c24d and dce9510.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2565439c-9560-45a2-8f97-03e440ee1f88

📥 Commits

Reviewing files that changed from the base of the PR and between 7137ff9 and 0c3c24d.

📒 Files selected for processing (1)
  • src/web/adapter.mjs

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The simulator now accepts optional view settings and includes supported parameters in its URL. Vite now serves the app public directory, injects the app index, and exposes the relocated web distribution filesystem root.

Changes

Simulator web updates

Layer / File(s) Summary
Simulator view propagation
src/web/adapter.mjs
runSimulate passes the optional view object to startSimulatorServer. startSimulatorServer accepts the object.
Vite web serving configuration
src/web/adapter.mjs
The Vite configuration serves the app public directory, injects the app index, and exposes the relocated web distribution filesystem root.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: dashersw

Merge Risk: ⚪ Minimal · up to 0c3c2

The simulator preserves requested view settings and Vite exposes the relocated web assets; no concrete production-impacting issue is identified, so the change is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both primary changes: forwarding the view to the simulator server and configuring Vite to use the app's build roots.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@dashersw
dashersw force-pushed the fix/web-simulate-packaged-context branch from 0c3c24d to dce9510 Compare September 22, 2026 01:29
@dashersw
dashersw merged commit 3b8dc89 into main Sep 22, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants