Skip to content

Forward view to the simulator server and point vite at the app's build roots #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashersw merged 1 commit into from
Sep 22, 2026
Merged

Forward view to the simulator server and point vite at the app's build roots #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/web/adapter.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export function buildSimulatorApp({ app, env, dryRun = false, stdout }) {

export async function runSimulate({ ctx, app, env, dryRun = false, stdout, port, open = true, view = {} }) {
const { simulatorDir, paths } = buildSimulatorApp({ app, env, dryRun, stdout })
const url = await startSimulatorServer({ ctx, app, env, simulatorDir, paths, port, dryRun, stdout })
const url = await startSimulatorServer({ ctx, app, env, simulatorDir, paths, port, dryRun, stdout, view })
if (dryRun) return 0
stdout(`Simulating ${app.id}: ${url}`)
if (open) openBrowser(url, env)
Expand All @@ -166,7 +166,7 @@ export async function runSimulate({ ctx, app, env, dryRun = false, stdout, port,
// the relocated dist root be passed as inline config that vite merges over the
// package's own vite.config.ts, instead of being smuggled through env vars the
// config would have to read back.
async function startSimulatorServer({ ctx, app, env, simulatorDir, paths, port, dryRun, stdout }) {
async function startSimulatorServer({ ctx, app, env, simulatorDir, paths, port, dryRun, stdout, view = {} }) {
const appRoot = path.join(simulatorDir, 'simulator')
const configFile = path.join(appRoot, 'vite.config.ts')
if (dryRun) {
Expand All @@ -182,7 +182,11 @@ async function startSimulatorServer({ ctx, app, env, simulatorDir, paths, port,
// Vite's default cacheDir is <root>/node_modules/.vite -- inside the
// installed package, which may be read-only and is not this app's to dirty.
cacheDir: paths.viteCache,
define: { __GEA_APP_INDEX__: JSON.stringify(appIndexFor(ctx, app)) },
publicDir: path.dirname(paths.public),
define: {
__GEA_APP_INDEX__: JSON.stringify(appIndexFor(ctx, app)),
__GEA_WEB_DIST_FS_ROOT__: JSON.stringify(paths.dist)
},
server: {
port,
fs: { allow: [appRoot, paths.dist, paths.public] }
Expand Down
Loading