Skip to content

feat!: add support for crash-time attachments via hint - #2112

Merged
jpnurmi merged 4 commits into
jpnurmi/feat/hintsfrom
jpnurmi/feat/crash-hints
Sep 22, 2026
Merged

jpnurmi merged 4 commits into
jpnurmi/feat/hintsfrom
jpnurmi/feat/crash-hints

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Merge attachments and pass as hint to on_crash, then use the resulting hint attachments in the envelope.

Caution

BREAKING CHANGE: on_crash callbacks now have an additional sentry_hint_t *hint parameter.

Close: #2098

@jpnurmi
jpnurmi added this pull request to stack #2113 September 18, 2026 16:49
@jpnurmi
jpnurmi marked this pull request as draft September 18, 2026 16:49

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d30860a. Configure here.

Comment thread src/backends/sentry_backend_crashpad.cpp
Comment thread src/backends/sentry_backend_native.c
Comment thread src/backends/sentry_backend_inproc.c
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.08861% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.42%. Comparing base (98b9bfe) to head (cf8a5b8).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           jpnurmi/feat/hints    #2112      +/-   ##
======================================================
+ Coverage               75.33%   75.42%   +0.09%     
======================================================
  Files                     103      103              
  Lines                   27939    28026      +87     
  Branches                 5103     5114      +11     
======================================================
+ Hits                    21049    21140      +91     
+ Misses                   5559     5550       -9     
- Partials                 1331     1336       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crash-hints branch 2 times, most recently from fb6c4ac to 579efa4 Compare September 21, 2026 14:53
@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crash-hints branch from 579efa4 to 902cae1 Compare September 21, 2026 16:10
@jpnurmi
jpnurmi marked this pull request as ready for review September 21, 2026 16:21
@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crash-hints branch from d8f1a2a to 6f6faf1 Compare September 21, 2026 19:23
Comment thread src/backends/sentry_backend_native.c
@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crash-hints branch from 6f6faf1 to 0bfe140 Compare September 22, 2026 10:19
Comment thread src/sentry_hint.c
Comment thread src/backends/sentry_backend_crashpad.cpp
@jpnurmi
jpnurmi force-pushed the jpnurmi/feat/crash-hints branch from 94c9905 to cf8a5b8 Compare September 22, 2026 12:08
@jpnurmi
jpnurmi merged commit 288d661 into master Sep 22, 2026
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: hints

3 participants