Repository navigation
fix: apply the saved FPS counter when a session starts - #139
Merged
Merged
Conversation
The engine rebuilt AppConfig field by field for the session and left out FpsOverlay and FpsOverlayLayout, so Start always saw the default style. The copy is now a clone with only the monitor fields swapped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes The initial review covers the config-copy change, its session-start FPS overlay behavior, tests, and accompanying documentation.
- Preserve settings during monitor resolution
WithMonitorsclonesAppConfigand swaps only the resolved monitor fields, so saved FPS overlay settings reach session startup. - Add regression coverage Tests verify monitor replacements and preservation of the FPS settings and other writable config properties.
- Document and verify the fix Both changelogs and the manual testing checklist describe the saved-style startup scenario.
gpt-6-luna | 𝕏
This was referenced Oct 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
With an FPS counter style saved in Settings (Compact, Detailed, Custom or Off), starting a session showed no counter and left Afterburner's OSD on screen. It only took effect after cycling the "FPS counter" row in the session menu.
ConsoleEngine.ResolveMonitorNamesrebuiltAppConfigfield by field and left outFpsOverlayandFpsOverlayLayout(andControllerLayout), soStartalways saw the defaultexternal.Fix
AppConfig.WithMonitorsreturns a clone with only the three monitor fields swapped, so a setting added later is carried along by itself.Verification
docs/TESTING.md(start a session with a style already saved).🤖 Generated with Claude Code