WIP removing users.gh_login - #14575
Draft
carols10cents wants to merge 5 commits into
Draft
Conversation
Member
|
@carols10cents feel free to open these as individual PRs. the smaller they are, the easier to review :) |
Member
Author
see in the description where i said "Will be submitting these as separate PRs safe to deploy" 😁 |
carols10cents
force-pushed
the
remove-gh-login
branch
3 times, most recently
from
September 2, 2026 18:24
3b277e5 to
35bccac
Compare
carols10cents
force-pushed
the
remove-gh-login
branch
3 times, most recently
from
September 2, 2026 20:34
c0a863e to
0c8b6e3
Compare
This was referenced Sep 2, 2026
These are messages that a user sees when they've invited other users to own a crate. Right now, there shouldn't be any confusion because `users.username` should always equal `users.gh_login`, but I've added "Crates.io user" to the message to hopefully clarify for the future when we have crates.io usernames independent of GitHub usernames.
carols10cents
force-pushed
the
remove-gh-login
branch
from
September 3, 2026 19:31
0c8b6e3 to
15e4948
Compare
carols10cents
force-pushed
the
remove-gh-login
branch
from
September 3, 2026 20:03
aba5e00 to
62ebc4b
Compare
Collaborator
|
☔ The latest upstream changes (possibly #14581) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be submitting these as separate PRs safe to deploy