Repository navigation
docs(agents): require skill review and the CRAP report before review - #56
Merged
Merged
Conversation
CI runs neither the voltage-pr-review skill's diff review nor the manual CRAP report, so both were easy to skip. AGENTS.md now lists the checks that authors and reviewers, people or agents, run before a pull request is ready: the skill review against the base, tests for every new error path, the development guide's gate, and the CRAP report for changes under src/ or tests/. The pull request reports what ran and the CRAP result.
tee8z
approved these changes
Oct 20, 2026
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two required checks are easy to skip because CI runs neither:
voltage-pr-review(engineering-skills) reviews the diff against its base and the repository's rules.docs/quality.mdrequires every measured function to stay below 20, but the check is manual.On #55, a human review found a CRAP violation (
startup::executeat 20.15), a hand-writtenmatchwhereDisplaybelonged, and two untested error paths. Neither the author agent nor a review agent had run these checks.Change
AGENTS.mdgets a "Before you request review" section, for authors and reviewers, people or agents:voltage-pr-review; for Rust, alsovoltage-backend-engineeringand its style checklist. Fix findings first.docs/development.md.src/ortests/, run the CRAP report: every function below 20. Fix a violation in the PR that introduces it, without splitting functions only for the score.A reviewer runs the CRAP report on the PR head and reports violations as findings.
Validation
Docs only (+23 lines).
masterhas no docs link test yet, so I checked by hand thatdocs/development.mdexists and thatdocs/quality.mdhas a### CRAP risk checkheading (anchor#crap-risk-check). The CRAP report does not apply, because the change touches neithersrc/nortests/.